Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid Go Module pseudo-versions used by dependencies #1801

Merged
merged 1 commit into from
Sep 5, 2019
Merged

Fix invalid Go Module pseudo-versions used by dependencies #1801

merged 1 commit into from
Sep 5, 2019

Conversation

RJPercival
Copy link
Contributor

@RJPercival RJPercival commented Sep 5, 2019 •
edited
Loading

Override the invalid pseudo-versions with correct pseudo-versions that refer to the same commits.

Fixes #1786.

Checklist

Fix invalid Go Module pseudo-versions used by dependencies
da88986 
Override the invalid pseudo-versions with correct pseudo-versions that
refer to the same commits.
@RJPercival RJPercival requested a review from gdbelvin September 5, 2019 12:03
@google google deleted a comment from codecov bot Sep 5, 2019
@RJPercival RJPercival merged commit 459954a into google:master Sep 5, 2019
@RJPercival RJPercival deleted the gomod_pseudo_version_fix branch September 5, 2019 13:55
This was referenced Sep 5, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdbelvin gdbelvin gdbelvin approved these changes

Assignees

@gdbelvin gdbelvin

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

golangci-lint dependency on go-critic issue w/ golang 1.13 (works w/ <=golang:1.12.7)
3 participants
@RJPercival @gdbelvin @googlebot